Bug 26719 - A few fixes for bugzilla-tool
Summary: A few fixes for bugzilla-tool
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-25 04:35 PDT by Tor Arne Vestbø
Modified: 2009-06-25 14:26 PDT (History)
0 users

See Also:


Attachments
bugzilla-tool: use unicode instead of str when fetching the patch name (1.42 KB, patch)
2009-06-25 04:40 PDT, Tor Arne Vestbø
levin: review+
Details | Formatted Diff | Diff
bugzilla-tool: Add Simon Hausmann as reviewer (990 bytes, patch)
2009-06-25 04:40 PDT, Tor Arne Vestbø
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tor Arne Vestbø 2009-06-25 04:35:51 PDT
A few fixes for bugzilla-tool
Comment 1 Tor Arne Vestbø 2009-06-25 04:40:12 PDT
Created attachment 31852 [details]
bugzilla-tool: use unicode instead of str when fetching the patch name

---
 2 files changed, 9 insertions(+), 1 deletions(-)
Comment 2 Tor Arne Vestbø 2009-06-25 04:40:16 PDT
Created attachment 31853 [details]
bugzilla-tool: Add Simon Hausmann as reviewer

---
 2 files changed, 9 insertions(+), 0 deletions(-)
Comment 3 Jan Alonzo 2009-06-25 04:50:49 PDT
Comment on attachment 31853 [details]
bugzilla-tool: Add Simon Hausmann as reviewer

> +++ b/WebKitTools/Scripts/modules/bugzilla.py
> @@ -89,6 +89,7 @@ class Bugzilla:
>          "eric" : "Eric Seidel",
>          "fishd" : "Darin Fisher",
>          "gns" : "Gustavo Noronha",
> +        "hausmann" : "Simon Hausmann",

r=me.
Comment 4 David Levin 2009-06-25 09:00:31 PDT
Comment on attachment 31852 [details]
bugzilla-tool: use unicode instead of str when fetching the patch name

Please add the link to the bug in the changelog (even though in this case it doesn't really add anything).
Comment 5 Eric Seidel (no email) 2009-06-25 10:10:14 PDT
Yup, these look good.
Comment 6 Eric Seidel (no email) 2009-06-25 13:37:43 PDT
I'm not sure why this is assigned to me?  Unless I'm supposed to land it?
Comment 7 Eric Seidel (no email) 2009-06-25 14:10:58 PDT
I need the reviewer fix, so will land.
Comment 8 Eric Seidel (no email) 2009-06-25 14:12:55 PDT
svn-apply doesn't seem to fix the ChangeLog correctly when applying this.  Odd.
Comment 9 Eric Seidel (no email) 2009-06-25 14:18:19 PDT
Comment on attachment 31853 [details]
bugzilla-tool: Add Simon Hausmann as reviewer

This was already commited: http://trac.webkit.org/changeset/45174
Comment 10 Eric Seidel (no email) 2009-06-25 14:26:31 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/modules/bugzilla.py
Committed r45192
http://trac.webkit.org/changeset/45192