WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
267188
Introduce enum classes to identify and categorize events
https://bugs.webkit.org/show_bug.cgi?id=267188
Summary
Introduce enum classes to identify and categorize events
Ryosuke Niwa
Reported
2024-01-06 14:49:11 PST
Introduce enums to identify each event as well as categorize events. This allows fast comparison compared to a bunch of related AtomString::operator== comparisons.
Attachments
WIP
(6.40 KB, patch)
2024-01-06 16:00 PST
,
Ryosuke Niwa
no flags
Details
Formatted Diff
Diff
WIP2
(55.84 KB, patch)
2024-01-06 16:01 PST
,
Ryosuke Niwa
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
WIP3
(55.45 KB, patch)
2024-01-07 00:26 PST
,
Ryosuke Niwa
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
WIP3 with logging
(56.46 KB, patch)
2024-01-07 00:53 PST
,
Ryosuke Niwa
no flags
Details
Formatted Diff
Diff
WIP3 with logging 2
(56.51 KB, patch)
2024-01-07 01:07 PST
,
Ryosuke Niwa
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
WIP3 with logging 3
(56.51 KB, patch)
2024-01-07 01:37 PST
,
Ryosuke Niwa
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(6)
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2024-01-06 16:00:26 PST
Created
attachment 469317
[details]
WIP
Ryosuke Niwa
Comment 2
2024-01-06 16:01:13 PST
Created
attachment 469318
[details]
WIP2
Ryosuke Niwa
Comment 3
2024-01-07 00:26:42 PST
Created
attachment 469322
[details]
WIP3
Ryosuke Niwa
Comment 4
2024-01-07 00:53:26 PST
Created
attachment 469324
[details]
WIP3 with logging
Ryosuke Niwa
Comment 5
2024-01-07 01:07:14 PST
Created
attachment 469325
[details]
WIP3 with logging 2
Ryosuke Niwa
Comment 6
2024-01-07 01:37:23 PST
Created
attachment 469326
[details]
WIP3 with logging 3
Ryosuke Niwa
Comment 7
2024-01-07 02:50:04 PST
Pull request:
https://github.com/WebKit/WebKit/pull/22484
EWS
Comment 8
2024-01-08 23:09:23 PST
Committed
272801@main
(490b4fdda464): <
https://commits.webkit.org/272801@main
> Reviewed commits have been landed. Closing PR #22484 and removing active labels.
Radar WebKit Bug Importer
Comment 9
2024-01-08 23:10:16 PST
<
rdar://problem/120693336
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug