Bug 267171 – REGRESSION(272726@main): broke WebKitGTK and WPE builds

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Commit Bot]

https://commits.webkit.org/272726@main introduced a regression:
broke WebKitGTK and WPE builds

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.

[WebKit Commit Bot]

Created attachment 469306 [details]
REVERT of 272726@main

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the revert will be successful.  This process takes approximately 15 minutes.

If you would like to land the revert faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Diego Pino]

WebKitGTK and WPE build stops with the following:

```
CMake Error at Source/cmake/WebKitMacros.cmake:118 (target_sources):
  Cannot find source file:

    /app/webkit/WebKitBuild/GTK/Release/WebCore/DerivedSources/UserAgentPartIds.cpp

  Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .ixx .cppm
  .ccm .cxxm .c++m .h .hh .h++ .hm .hpp .hxx .in .txx .f .F .for .f77 .f90
  .f95 .f03 .hip .ispc
Call Stack (most recent call first):
  Source/cmake/WebKitMacros.cmake:322 (_WEBKIT_TARGET)
  Source/WebCore/CMakeLists.txt:2870 (WEBKIT_FRAMEWORK)


CMake Error in Source/WebCore/CMakeLists.txt:
  Cannot find source file:

    /app/webkit/WebKitBuild/GTK/Release/WebCore/DerivedSources/UserAgentPartIds.h

  Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .ixx .cppm
  .ccm .cxxm .c++m .h .hh .h++ .hm .hpp .hxx .in .txx .f .F .for .f77 .f90
  .f95 .f03 .hip .ispc
```

The build issue can be triggered on a clean build. The EWS WebKitGTK and WPE build bots were green becasue they do not remove DerivedSources, so they still had a copy of 'UserAgentPartIds.h' and 'UserAgentPartIds.cpp'.

[EWS]

Committed 272727@main (33d602613bae): <https://commits.webkit.org/272727@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 469306 [details].

[Radar WebKit Bug Importer]

<rdar://problem/120580415>

[WebKit Commit Bot]

Re-opened since this is blocked by bug 267173

[Philippe Normand]

Great to step on each other feet :( The fix i merged will now break the build again.