WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
267111
Improve overflow handing ergonomics in JSStringJoiner::append().
https://bugs.webkit.org/show_bug.cgi?id=267111
Summary
Improve overflow handing ergonomics in JSStringJoiner::append().
Mark Lam
Reported
2024-01-04 17:32:34 PST
Currently, JSStringJoiner::append() appends to its m_string Vector. As a result, if an overflow is imminent, it crashes. We change the code to use tryAppend() instead and remember if an overflow was detected. If so, JSStringJoiner::join() can throw an OutOfMemory error later.
rdar://120389377
Attachments
Add attachment
proposed patch, testcase, etc.
Mark Lam
Comment 1
2024-01-04 17:49:23 PST
Pull request:
https://github.com/WebKit/WebKit/pull/22412
EWS
Comment 2
2024-01-05 08:27:39 PST
Committed
272688@main
(21dd74926ee0): <
https://commits.webkit.org/272688@main
> Reviewed commits have been landed. Closing PR #22412 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug