Bug 267102 - REGRESSION (270199@main): [iOS] Viewport units are incorrect in Safari after entering and exiting fullscreen
Summary: REGRESSION (270199@main): [iOS] Viewport units are incorrect in Safari after ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aditya Keerthi
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-01-04 15:11 PST by Aditya Keerthi
Modified: 2024-01-05 00:45 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aditya Keerthi 2024-01-04 15:11:41 PST 
https://commits.webkit.org/270199@main resets overridden layout parameters to garbage values due to re-implementations of existing WKWebView methods with a different return type:

```
@property (nonatomic, readonly) std::optional<CGSize> _minimumUnobscuredSizeOverride;
@property (nonatomic, readonly) std::optional<CGSize> _maximumUnobscuredSizeOverride;
```

But these were already implemented as methods returning CGSize.
Comment 1 Radar WebKit Bug Importer 2024-01-04 15:12:02 PST 
<rdar://problem/120496571>
Comment 2 Aditya Keerthi 2024-01-04 15:54:39 PST 
Pull request: https://github.com/WebKit/WebKit/pull/22407
Comment 3 EWS 2024-01-05 00:45:36 PST 
Committed 272679@main (53929a96966c): <https://commits.webkit.org/272679@main>

Reviewed commits have been landed. Closing PR #22407 and removing active labels.