RESOLVED FIXED267091
Factor PDF JS evaluation out of PDFPlugin 
https://bugs.webkit.org/show_bug.cgi?id=267091
Summary Factor PDF JS evaluation out of PDFPlugin
Tim Horton
Reported 2024-01-04 10:35:57 PST
Factor PDF JS evaluation out of PDFPlugin
Attachments
Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2024-01-04 10:43:08 PST
Pull request: https://github.com/WebKit/WebKit/pull/22391
Tim Horton
Comment 2 2024-01-04 10:43:12 PST
rdar://118550726
EWS
Comment 3 2024-01-05 14:35:54 PST
Committed 272706@main (0474d6003056): <https://commits.webkit.org/272706@main> Reviewed commits have been landed. Closing PR #22391 and removing active labels.
Jonathan Bedard
Comment 4 2024-01-08 20:53:42 PST
Looks like this change caused a regression in TestWebKitAPI.PDF.PrintSize: https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.PDF.PrintSize
Tim Horton
Comment 5 2024-01-10 17:00:51 PST
It sure does! Looking.
Tim Horton
Comment 6 2024-01-10 17:37:12 PST
(In reply to Tim Horton from comment #5) > It sure does! Looking. Weird, passes here.
Tim Horton
Comment 7 2024-01-10 17:39:40 PST
(In reply to Tim Horton from comment #6) > (In reply to Tim Horton from comment #5) > > It sure does! Looking. > > Weird, passes here. The bots are also bizarrely inconsistent, I can't puzzle out the rhyme or reason
Tim Horton
Comment 8 2024-01-11 03:08:35 PST
ok, I have a fix. will post a patch tomorrow. There's something weird about one of the bots where it claims to be AS but is acting like Intel.
Tim Horton
Comment 9 2024-01-11 03:25:38 PST
(In reply to Tim Horton from comment #8) > ok, I have a fix. will post a patch tomorrow. -> https://bugs.webkit.org/show_bug.cgi?id=267403
Note You need to log in before you can comment on or make changes to this bug.