Bug 266991 - Rename GridBaselineAlignment's baselineAxis variables and GridBaselineAlignment::GridBaselineAlignment::isHorizontalBaselineAxis
Summary: Rename GridBaselineAlignment's baselineAxis variables and GridBaselineAlignme...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sammy Gill
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-01-02 11:03 PST by Sammy Gill
Modified: 2024-01-02 13:21 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sammy Gill 2024-01-02 11:03:27 PST 
There are better spec terms that we can use in these cases that make reading the code quite a bit clearer. See https://drafts.csswg.org/css-align-3/
Comment 1 Radar WebKit Bug Importer 2024-01-02 11:03:46 PST 
<rdar://problem/120378682>
Comment 2 Sammy Gill 2024-01-02 11:15:31 PST 
Pull request: https://github.com/WebKit/WebKit/pull/22311
Comment 3 EWS 2024-01-02 13:21:45 PST 
Committed 272579@main (fcb681a31f03): <https://commits.webkit.org/272579@main>

Reviewed commits have been landed. Closing PR #22311 and removing active labels.