Bug 26696 - Member functions in DataGridColumnList should return pointers instead of PassRefPtr
Summary: Member functions in DataGridColumnList should return pointers instead of Pass...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-24 15:26 PDT by David Levin
Modified: 2009-06-24 15:48 PDT (History)
0 users

See Also:


Attachments
Proposed fix. (3.80 KB, patch)
2009-06-24 15:35 PDT, David Levin
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2009-06-24 15:26:05 PDT
The PassRefPtr is usually returned to indicate that the ref count is being passed and that isn't the case here.  The class still maintains a ref count on these items.


(Besides just that general idea, I'm doing this because it helps me get our autogenerated code for v8 bindings building.)
Comment 1 David Levin 2009-06-24 15:35:54 PDT
Created attachment 31814 [details]
Proposed fix.
Comment 2 Dave Hyatt 2009-06-24 15:38:06 PDT
Comment on attachment 31814 [details]
Proposed fix.

r=me
Comment 3 David Levin 2009-06-24 15:48:31 PDT
Committed as http://trac.webkit.org/changeset/45111