Bug 266954 – Allow non-SVG Elements for SVG animation event-bases

• Status: NEW
• Component: SVG

[Ahmad Saleem]

Hi Team,

While looking into Blink commit and matching with WebKit's, I noticed that we can merge following:

Blink Commit: https://chromium.googlesource.com/chromium/blink/+/111ccefde5e2f747b600500b71e6737533bc5241

WebKit Source: https://searchfox.org/wubkat/rev/af9971e796398c1d012ef5df9a09ed580d19bd17/Source/WebCore/svg/animation/SVGSMILElement.cpp#562

We have 'Element' here, while we should restrict it to 'SVGElement'. We don't have to merge and do all changes, following compiles:

In 'SVGSMILElement.cpp':

inline RefPtr<SVGElement> SVGSMILElement::eventBaseFor(const Condition& condition)
{
    RefPtr eventBase = condition.m_baseID.isEmpty() ? RefPtr<Element> { targetElement() } : treeScope().getElementById(condition.m_baseID);
    if (eventBase && eventBase->isSVGElement())
        return downcast<SVGElement>(eventBase);
    return nullptr;
}

and

equivalent in SVGSMILElement.h:

    RefPtr<SVGElement> eventBaseFor(const Condition&);

___

Just wanted to raise to get input.

Thanks!

[Ahmad Saleem]

We have WPT test case as well, which we fail:

https://wpt.fyi/results/svg/animations/eventbase-non-svg-element.html?label=master&label=experimental&aligned=&q=eventbase

Although my changes does not lead to progress this at least while running via Minibrowser.

[Ahmad Saleem]

(In reply to Ahmad Saleem from comment #1)
> We have WPT test case as well, which we fail:
> 
> https://wpt.fyi/results/svg/animations/eventbase-non-svg-element.
> html?label=master&label=experimental&aligned=&q=eventbase
> 
> Although my changes does not lead to progress this at least while running
> via Minibrowser.

NOTE - WPT is opposite of Blink merge, so we shouldn't change but should look for why we fail this test.

[Radar WebKit Bug Importer]

<rdar://problem/120617438>