Bug 266948 - `:has-attachment` pseudo-class should be prefixed
Summary: `:has-attachment` pseudo-class should be prefixed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-12-31 04:23 PST by Tim Nguyen (:ntim)
Modified: 2024-01-09 09:50 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2023-12-31 04:23:11 PST 
-apple-has-attachment seems like the logical choice given it's only exposed to the Apple apps.
Comment 1 Tim Nguyen (:ntim) 2023-12-31 04:23:39 PST 
It also should not parse when <attachment> isn't enabled.
Comment 2 Tim Nguyen (:ntim) 2023-12-31 04:24:24 PST 
(In reply to Tim Nguyen (:ntim) from comment #1)
> It also should not parse when <attachment> isn't enabled.

That part is already the case: https://searchfox.org/wubkat/rev/0d695812f5b0daef531a9760903457364d2265ff/Source/WebCore/css/parser/CSSSelectorParser.cpp#783-786
Comment 3 Radar WebKit Bug Importer 2024-01-06 19:33:51 PST 
<rdar://problem/120599170>
Comment 4 Tim Nguyen (:ntim) 2024-01-06 19:38:53 PST 
Pull request: https://github.com/WebKit/WebKit/pull/22478
Comment 5 EWS 2024-01-09 08:15:11 PST 
Committed 272820@main (ee0b8ecdb38d): <https://commits.webkit.org/272820@main>

Reviewed commits have been landed. Closing PR #22478 and removing active labels.
Comment 6 Tim Nguyen (:ntim) 2024-01-09 09:47:57 PST 
Re-opening for pull request https://github.com/WebKit/WebKit/pull/22544
Comment 7 EWS 2024-01-09 09:50:48 PST 
Committed 272821@main (4f86be215342): <https://commits.webkit.org/272821@main>

Reviewed commits have been landed. Closing PR #22544 and removing active labels.