RESOLVED FIXED 266919
Add early return in 'prepareWhitespaceAtPositionForSplit' if there is no richly editable position 
https://bugs.webkit.org/show_bug.cgi?id=266919
Summary Add early return in 'prepareWhitespaceAtPositionForSplit' if there is no rich...
Ahmad Saleem
Reported 2023-12-27 18:52:34 PST
Hi Team, While looking into HTML Editing code in Blink, I noticed that they have early return for 'prepareWhitespaceAtPositionForSplit'. Blink Commit: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/editing/commands/composite_edit_command.cc;l=814;drc=3adc67dbb288622b53c188b0858ec898626998ae WebKit Source: https://searchfox.org/wubkat/rev/2cb2f84b68df8a519e252d535de43e7d19567883/Source/WebCore/editing/CompositeEditCommand.cpp#977 Following compiles: if (!isRichlyEditablePosition(position)) return; ___ I don't have any benchmark or test cases run through above change but it does not seems like bad idea. Thanks!
Attachments
Add attachment proposed patch, testcase, etc.
EWS
Comment 1 2024-01-02 10:22:11 PST
Committed 272570@main (77a2ca7c64f9): <https://commits.webkit.org/272570@main> Reviewed commits have been landed. Closing PR #22254 and removing active labels.
Radar WebKit Bug Importer
Comment 2 2024-01-02 10:23:14 PST
<rdar://problem/120376672>
Note You need to log in before you can comment on or make changes to this bug.