WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
266908
Remove unused 'valueShouldChangeOnHotTrack' function
https://bugs.webkit.org/show_bug.cgi?id=266908
Summary
Remove unused 'valueShouldChangeOnHotTrack' function
Ahmad Saleem
Reported
2023-12-26 18:22:32 PST
Hi Team, Noticed that 'valueShouldChangeOnHotTrack' is unused or returning 'true' / 'false' without any call site across code.
https://searchfox.org/wubkat/rev/2cb2f84b68df8a519e252d535de43e7d19567883/Source/WebCore/platform/PopupMenuClient.h#64
https://searchfox.org/wubkat/rev/2cb2f84b68df8a519e252d535de43e7d19567883/Source/WebCore/rendering/RenderMenuList.h#114
https://searchfox.org/wubkat/rev/2cb2f84b68df8a519e252d535de43e7d19567883/Source/WebCore/rendering/RenderSearchField.h#78
Just raising to see, if we can try to remove it and whether it leads to any failure or not. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
EWS
Comment 1
2023-12-26 21:01:20 PST
Committed
272507@main
(7ee701c3a6f7): <
https://commits.webkit.org/272507@main
> Reviewed commits have been landed. Closing PR #22247 and removing active labels.
Radar WebKit Bug Importer
Comment 2
2023-12-26 21:02:12 PST
<
rdar://problem/120194318
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug