RESOLVED FIXED 266906
Remove unused 'HTMLSelectElement::deselectItems' function 
https://bugs.webkit.org/show_bug.cgi?id=266906
Summary Remove unused 'HTMLSelectElement::deselectItems' function
Ahmad Saleem
Reported 2023-12-26 17:16:27 PST
Hi Team, While looking into HTMLSelectElement code, it seems that 'deselectItems' code is just referring to another function and there are no call-sites while looking into 'searchfox.org' (wubkat). I think we can safely remove this and make code bit cleaner. WebKit Source: https://github.com/WebKit/WebKit/blob/f9465ea35d9a2969110e5955b30d8c11bc699c91/Source/WebCore/html/HTMLSelectElement.cpp#L118 https://github.com/WebKit/WebKit/blob/f9465ea35d9a2969110e5955b30d8c11bc699c91/Source/WebCore/html/HTMLSelectElement.h#L159 Just wanted to raise so we can try PR and see if it leads to any regression etc. Thanks!
Attachments
Add attachment proposed patch, testcase, etc.
EWS
Comment 1 2023-12-26 19:36:19 PST
Committed 272505@main (26d8e95af97e): <https://commits.webkit.org/272505@main> Reviewed commits have been landed. Closing PR #22245 and removing active labels.
Radar WebKit Bug Importer
Comment 2 2023-12-26 19:37:15 PST
<rdar://problem/120191192>
Note You need to log in before you can comment on or make changes to this bug.