WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
266897
Exposing navigator.language to web workers
https://bugs.webkit.org/show_bug.cgi?id=266897
Summary
Exposing navigator.language to web workers
Ahmad Saleem
Reported
2023-12-26 11:03:45 PST
Hi Team, While investigating WPT failures, I noticed that we fail two tests here: WPT Test Case:
https://wpt.fyi/results/html/dom/idlharness.worker.html?label=master&label=experimental&aligned=&q=safari%3Afail
> WorkerGlobalScope interface: attribute onlanguagechange > WorkerGlobalScope interface: self must inherit property "onlanguagechange" with the proper type
WebKit / Safari is only browser currently failing these (so I will add 'BrowserCompat' tag - in addition to 'WPTImpact'). Blink Commit (for reference) -
https://chromium.googlesource.com/chromium/src.git/+/6c688717fa4d50920ebcb0ab80e95023ff562656
FIXME in WebKit Source:
https://searchfox.org/wubkat/rev/2cb2f84b68df8a519e252d535de43e7d19567883/Source/WebCore/workers/WorkerGlobalScope.idl#39
I didn't manage to find similar bug so I thought to raise for better tracking. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
Ahmad Saleem
Comment 1
2023-12-26 11:11:07 PST
NOTE - just uncommenting in IDL file (FIXME) leads to test progression. So we might have already necessary implementation. Although, will wait for more context or input from others.
Alexey Proskuryakov
Comment 2
2023-12-26 12:20:09 PST
Language.cpp has some locking added for OffscreenCanvas thread safety, so Navigator.language may indeed be trivial to enable in workers at this point. Careful verification would still be needed, of course. However onlanguagechange clearly doesn't have an implementation, so uncommenting the line in IDL won't make it work.
Radar WebKit Bug Importer
Comment 3
2024-01-02 11:04:14 PST
<
rdar://problem/120378717
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug