Skia did an backwards-incompatible api change (r232, 235, 236, 239 at http://code.google.com/p/skia/source/list ). Use the new api.
Created attachment 31790 [details] Use new skia api
The change looks fine. I need some Chromium person to confirm this is correct, and then I can r+ it. setXfermodeMode is about the worst method name ever. I'm surprised Skia is moving from "PorterDuffMode" which actually made some sense, to "XfermodeMode" which is just silly. ;)
LGTM
Created attachment 31809 [details] Fill in bug, reviewer, and email fields
Comment on attachment 31809 [details] Fill in bug, reviewer, and email fields You don't generally fill in the reviewer. The committer will do that (or the commit script will).
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/platform/graphics/skia/GraphicsContextSkia.cpp M WebCore/platform/graphics/skia/ImageBufferSkia.cpp M WebCore/platform/graphics/skia/ImageSkia.cpp M WebCore/platform/graphics/skia/PlatformContextSkia.cpp M WebCore/platform/graphics/skia/PlatformContextSkia.h M WebCore/platform/graphics/skia/SkiaUtils.cpp M WebCore/platform/graphics/skia/SkiaUtils.h Committed r45103 http://trac.webkit.org/changeset/45103
Dudes, come on -- not cool. We've been trying to get the integration builder green for the last 3 days so that abarth and japhet could land their patches, and now this ... http://build.chromium.org/buildbot/waterfall.fyi/builders/Webkit%20(webkit.org)/builds/6294
I'm happy to roll it out. Or you're welcome to Dimitri. Your call.
Apologies for being a bad sport. This is being taken care of downstream as we speak.