Bug 266838 - Refactor RenderGrid::computeContentPositionAndDistributionOffset and contentDistributionOffset
Summary: Refactor RenderGrid::computeContentPositionAndDistributionOffset and contentD...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: Safari 17
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-12-22 23:32 PST by fantasai
Modified: 2024-01-02 19:23 PST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description fantasai 2023-12-22 23:32:21 PST
These functions are doing weird things like:
* Treating negative offsets as flagging an invalid state even though offsets can validly be negative.
* Letting control flow through in some cases without an obvious initialization to zero, but then insisting on setting things to zero in other cases... like either we're starting at zero and don't need to set it, or we need to set things to zero, pick one.
Comment 1 Radar WebKit Bug Importer 2023-12-22 23:32:33 PST
<rdar://problem/120064485>
Comment 2 EWS 2024-01-02 19:23:27 PST
Committed 272591@main (9c0b2b0c72a4): <https://commits.webkit.org/272591@main>

Reviewed commits have been landed. Closing PR #22219 and removing active labels.