WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
266838
Refactor RenderGrid::computeContentPositionAndDistributionOffset and contentDistributionOffset
https://bugs.webkit.org/show_bug.cgi?id=266838
Summary
Refactor RenderGrid::computeContentPositionAndDistributionOffset and contentD...
fantasai
Reported
2023-12-22 23:32:21 PST
These functions are doing weird things like: * Treating negative offsets as flagging an invalid state even though offsets can validly be negative. * Letting control flow through in some cases without an obvious initialization to zero, but then insisting on setting things to zero in other cases... like either we're starting at zero and don't need to set it, or we need to set things to zero, pick one.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-12-22 23:32:33 PST
<
rdar://problem/120064485
>
EWS
Comment 2
2024-01-02 19:23:27 PST
Committed
272591@main
(9c0b2b0c72a4): <
https://commits.webkit.org/272591@main
> Reviewed commits have been landed. Closing PR #22219 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug