WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
266836
Make Node's OptionSet<TypeFlag> more robust
https://bugs.webkit.org/show_bug.cgi?id=266836
Summary
Make Node's OptionSet<TypeFlag> more robust
Ryosuke Niwa
Reported
2023-12-22 22:23:56 PST
Right now, we specify OptionSet<TypeFlag> which is the union of all values we need in the most derived classes which specifies OptionSet<TypeFlag>. This is rather fragile since each derived class is responsible for specifying all ancestor class's types. Specify each TypeFlag at each Node class hierarchy instead to make it more robust.
Attachments
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2023-12-22 22:34:23 PST
Pull request:
https://github.com/WebKit/WebKit/pull/22215
Radar WebKit Bug Importer
Comment 2
2023-12-29 22:24:12 PST
<
rdar://problem/120285961
>
Ryosuke Niwa
Comment 3
2024-01-02 10:25:47 PST
Pull request:
https://github.com/WebKit/WebKit/pull/22308
EWS
Comment 4
2024-01-02 16:28:46 PST
Committed
272587@main
(cd960b2c7a54): <
https://commits.webkit.org/272587@main
> Reviewed commits have been landed. Closing PR #22308 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug