Bug 26680 – ENABLE_SVG=0 doesn't build

• Status: RESOLVED
• Resolution: WORKSFORME
• Component: SVG

[Yong Li]

1. TransformationMatrix::mapPoint(const FloatPoint3D&) relies on ENABLE(SVG)

#if ENABLE(SVG)
    // Map a 3D point through the transform, returning a 3D point.
    FloatPoint3D mapPoint(const FloatPoint3D&) const;
#endif

2. computeZOffset(const HitTestingTransformState& transformState) calls TransformationMatrix::mapPoint(const FloatPoint3D&) without checking ENABLE(SVG)

Solutions: 

a) remove #if ENABLE(SVG) from TransformationMatrix

or,

b) add #if ENABLE(SVG) to computeZOffset()

[Rob Buis]

It compiled fine on OS X for me, should we close this?
Cheers,

Rob.

[Yong Li]

weird. How could it happen?

// (no ENABLE(SVG) check here)
    FloatPoint3D backmappedPoint = transformState.m_accumulatedTransform.mapPoint(FloatPoint3D(targetPoint));


class TransformationMatrix
{
...
#if ENABLE(SVG)
    // Map a 3D point through the transform, returning a 3D point.
    FloatPoint3D mapPoint(const FloatPoint3D&) const;
#endif
...
};

[Dirk Schulze]

(In reply to comment #2)
> weird. How could it happen?
> 
> // (no ENABLE(SVG) check here)
>     FloatPoint3D backmappedPoint =
> transformState.m_accumulatedTransform.mapPoint(FloatPoint3D(targetPoint));
> 
> 
> class TransformationMatrix
> {
> ...
> #if ENABLE(SVG)
>     // Map a 3D point through the transform, returning a 3D point.
>     FloatPoint3D mapPoint(const FloatPoint3D&) const;
> #endif
> ...
> };

TransformationMatrix has no relation to SVG. WebKit compiles here without svg. I'm closing this bug now.