Bug 26675 - Allow custom memory allocation control for JavaScriptCore's Register class
Summary: Allow custom memory allocation control for JavaScriptCore's Register class
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
Depends on: 26686
  Show dependency treegraph
Reported: 2009-06-24 05:10 PDT by Zoltan Horvath
Modified: 2009-06-24 18:10 PDT (History)
0 users

See Also:

proposed patch (1.07 KB, patch)
2009-06-24 05:14 PDT, Zoltan Horvath
no flags Details | Formatted Diff | Diff
updated proposed patch (1.06 KB, patch)
2009-06-24 11:25 PDT, Zoltan Horvath
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2009-06-24 05:10:52 PDT
Inherits Register class from FastAllocBase because it has been instantiated by
'new' in JavaScriptCore/runtime/JSVariableObject.h:149.
Comment 1 Zoltan Horvath 2009-06-24 05:14:37 PDT
Created attachment 31782 [details]
proposed patch
Comment 2 Darin Adler 2009-06-24 09:54:23 PDT
Comment on attachment 31782 [details]
proposed patch

Explicit qualification by WTF:: should not be necessary. The pattern in WTF is that we put "using" statements into the files. It's a bit unusual for C++ code but I've been convinced by the other WTF developers that it's the right pattern. So we should patch FastAllocBase to include:

    using WTF::FastAllocBase;

And call the class just FastAllocBase everywhere we use it.
Comment 3 Zoltan Horvath 2009-06-24 11:25:41 PDT
Created attachment 31793 [details]
updated proposed patch
Comment 4 Zoltan Horvath 2009-06-24 11:33:28 PDT
I've filed a bug #26686 with FastAllocBase.h modifications and unnecessary WTF:: removes.

I've updated my uploaded bugs also: bug #26676 ; bug #26677 and this also.
Comment 5 Maciej Stachowiak 2009-06-24 12:15:51 PDT
Comment on attachment 31793 [details]
updated proposed patch

Comment 6 Eric Seidel (no email) 2009-06-24 16:54:29 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	JavaScriptCore/ChangeLog
	M	JavaScriptCore/interpreter/Register.h
Committed r45121
Comment 7 David Levin 2009-06-24 18:10:06 PDT
This patch need a fix to build: http://trac.webkit.org/changeset/45128