Bug 26675 – Allow custom memory allocation control for JavaScriptCore's Register class

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Zoltan Horvath]

Inherits Register class from FastAllocBase because it has been instantiated by
'new' in JavaScriptCore/runtime/JSVariableObject.h:149.

[Zoltan Horvath]

Created attachment 31782 [details]
proposed patch

[Darin Adler]

Comment on attachment 31782 [details]
proposed patch

Explicit qualification by WTF:: should not be necessary. The pattern in WTF is that we put "using" statements into the files. It's a bit unusual for C++ code but I've been convinced by the other WTF developers that it's the right pattern. So we should patch FastAllocBase to include:

    using WTF::FastAllocBase;

And call the class just FastAllocBase everywhere we use it.

[Zoltan Horvath]

Created attachment 31793 [details]
updated proposed patch

[Zoltan Horvath]

I've filed a bug #26686 with FastAllocBase.h modifications and unnecessary WTF:: removes.

I've updated my uploaded bugs also: bug #26676 ; bug #26677 and this also.

[Maciej Stachowiak]

Comment on attachment 31793 [details]
updated proposed patch

r=me

[Eric Seidel (no email)]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	JavaScriptCore/ChangeLog
	M	JavaScriptCore/interpreter/Register.h
Committed r45121
http://trac.webkit.org/changeset/45121

[David Levin]

This patch need a fix to build: http://trac.webkit.org/changeset/45128