Bug 266743 – Remove 'DOMPointInit' constructor from DOMPoint.idl and DOMPointReadOnly.idl

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Ahmad Saleem]

Hi Team,

While trying to understand test failures in 'CSS' especially below:

https://wpt.fyi/results/css/geometry/DOMPoint-001.html?label=master&label=experimental&aligned&q=safari%3Afail

and

https://wpt.fyi/results/css/geometry/DOMPoint-002.html?label=master&label=experimental&aligned&q=safari%3Afail

and noticed this following comment as well.

https://github.com/WebKit/WebKit/blob/926054f254028ee2cc29b0e96a50cca42592ce66/Source/WebCore/dom/DOMPoint.idl#L31

"The DOMPointInit constructor exists in https://www.w3.org/TR/geometry-1/ but is removed in https://drafts.fxtf.org/geometry/"

and if I remove following line:

https://github.com/WebKit/WebKit/blob/926054f254028ee2cc29b0e96a50cca42592ce66/Source/WebCore/dom/DOMPoint.idl#L36

and also from here:

https://github.com/WebKit/WebKit/blob/926054f254028ee2cc29b0e96a50cca42592ce66/Source/WebCore/dom/DOMPointReadOnly.idl#L37

We start progressing above failing test case. I don't know whether we have C++ code for this constructor or not but just raising so we can fix it.

CCing - Matt & Simon for their input.

Thanks!

[Ahmad Saleem]

NOTE - I also have another change and it is to make both IDL files have 'Serializable' as required by web-spec in my local build.

[Ahmad Saleem]

This PR added following constructor:

https://commits.webkit.org/183333@main

[Ahmad Saleem]

(In reply to Ahmad Saleem from comment #2)
> This PR added following constructor:
> 
> https://commits.webkit.org/183333@main

Simple revert of this leads to compile failures in DOMQuad.cpp:

https://github.com/WebKit/WebKit/blob/5ce41d80d50760401a9399bc7cb3d3be7b97b58e/Source/WebCore/dom/DOMQuad.cpp#L40

[Radar WebKit Bug Importer]

<rdar://problem/120222447>

[EWS]

Committed 281192@main (98dc100a1cd7): <https://commits.webkit.org/281192@main>

Reviewed commits have been landed. Closing PR #31006 and removing active labels.