Bug 266705 - Stop using CheckedPtr / CheckedRef with GlyphDisplayListCacheEntry
Summary: Stop using CheckedPtr / CheckedRef with GlyphDisplayListCacheEntry
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-12-20 07:11 PST by Chris Dumez
Modified: 2023-12-20 10:53 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2023-12-20 07:11:24 PST 
Stop using CheckedPtr / CheckedRef with GlyphDisplayListCacheEntry. Use WeakPtr / WeakRef instead to generate more actionable crashes.

This tested as performance neutral on Speedometer.
Comment 1 Chris Dumez 2023-12-20 07:12:46 PST 
Pull request: https://github.com/WebKit/WebKit/pull/22103
Comment 2 EWS 2023-12-20 10:52:03 PST 
Committed 272357@main (6bf65b8c7675): <https://commits.webkit.org/272357@main>

Reviewed commits have been landed. Closing PR #22103 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-12-20 10:53:15 PST 
<rdar://problem/119943763>