Bug 26668 - AX: need a way to retrieve the language for an element
Summary: AX: need a way to retrieve the language for an element
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-23 18:49 PDT by chris fleizach
Modified: 2009-06-24 16:01 PDT (History)
0 users

See Also:


Attachments
patch (11.15 KB, patch)
2009-06-24 11:54 PDT, chris fleizach
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2009-06-23 18:49:51 PDT
elements can have the lang attribute or have a meta tag that specifies language

accessibility needs to be able to vend this
Comment 1 chris fleizach 2009-06-24 11:54:27 PDT
Created attachment 31799 [details]
patch
Comment 2 Oliver Hunt 2009-06-24 12:13:50 PDT
Comment on attachment 31799 [details]
patch

r=me

It would be great if AX tests could start using the js-test-* style result reporting as they make for much readable test out in browser, report failures nicer, and have a number of functions for testing certain kinds of equality.
Comment 3 Darin Adler 2009-06-24 13:45:10 PDT
Comment on attachment 31799 [details]
patch

> +    JSRetainPtr<JSStringRef> language(Adopt, toAXElement(thisObject)->language());

Is this adopt really correct?
Comment 4 chris fleizach 2009-06-24 14:21:54 PDT
i think so. it works, and i copied it from the description() method above
Comment 5 chris fleizach 2009-06-24 15:15:32 PDT
http://trac.webkit.org/changeset/45109
Comment 6 chris fleizach 2009-06-24 15:56:00 PDT
fixing windows build in progress
Comment 7 chris fleizach 2009-06-24 16:01:15 PDT
windows build fix in
http://trac.webkit.org/changeset/45112