Bug 266665 – REGRESSION(271428@main): [ iOS 17 ] imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-button-event-dispatch.tentative.html is a constant text failure

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Robert Jenner]

imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-button-event-dispatch.tentative.html 

is a constant text failure on iOS 17. 


HISTORY:
https://results.webkit.org/?platform=ios&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fsemantics%2Finvokers%2Finvoketarget-button-event-dispatch.tentative.html

DIFF URL:
https://build.webkit.org/results/Apple-iPadOS-17-Simulator-Debug-WK2-Tests/272285@main%20(548)/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-button-event-dispatch.tentative-pretty-diff.html

TEXT DIFF:
+++ /Volumes/Data/worker/Apple-iPadOS-17-Simulator-Debug-WK2-Tests/build/layout-test-results/imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-button-event-dispatch.tentative-actual.txt
@@ -1,8 +1,8 @@
 
 
-PASS event dispatches on click
-PASS event action is set to invokeAction
-PASS event action is set to invokeaction attribute
+FAIL event dispatches on click assert_true: event is InvokeEvent expected true got false
+FAIL event action is set to invokeAction assert_true: event is InvokeEvent expected true got false
+FAIL event action is set to invokeaction attribute assert_true: event is InvokeEvent expected true got false
 PASS event does not dispatch if click:preventDefault is called
 PASS event does not dispatch if invoker is disabled

[Radar WebKit Bug Importer]

<rdar://problem/119897560>

[Robert Jenner]

This is easily reproducible on iOS 17 ToT running the test as follows:

run-webkit-tests --iOS-simulator imported/w3c/web-platform-tests/html/semantics/invokers/invoketarget-button-event-dispatch.tentative.html 


It also has an extremely clear regression point in the history at: https://commits.webkit.org/271428@main

[EWS]

Test gardening commit 272308@main (1fb5505e86e1): <https://commits.webkit.org/272308@main>

Reviewed commits have been landed. Closing PR #22069 and removing active labels.

[Anne van Kesteren]

Hey Keith, it seems that one of the invoker tests doesn't quite run correctly on iOS. Would you want to take a look at it? (I tried to copy Lindsey as well and while autocomplete worked, Bugzilla could not find the email address.)

[Keith Cirkel]

Thanks for the ping, I’ll take a look!

[Tim Nguyen (:ntim)]

I suspect this is failing because it's using mouse actions on iOS which are unsupported there:

  const actions = new test_driver.Actions();
  await waitForRender();
  await actions.pointerMove(0, 0, {origin: element})
      .pointerDown({button: actions.ButtonType.LEFT})
      .pointerUp({button: actions.ButtonType.LEFT})
      .send();
  await waitForRender();

There are similar failures to this. 

I would suggest trying to use `test_driver.click(element)` instead.

[sideshowbarker]

(In reply to Tim Nguyen (:ntim) from comment #6)
> I suspect this is failing because it's using mouse actions on iOS which are
> unsupported there:
> …
> I would suggest trying to use `test_driver.click(element)` instead.

But does test_driver.click(element) actually work for iOS testing?

At least I know that previously we merged https://commits.webkit.org/270924@main to skip a test on iOS that was passing on all other platforms but failing on iOS — an iOS failure that I was able to reproducible locally — due just to that test relying on test_driver.click()

[Tim Nguyen (:ntim)]

Ah maybe not, maybe the test should just be skipped on iOS then.

[EWS]

Committed 272767@main (8e1133897599): <https://commits.webkit.org/272767@main>

Reviewed commits have been landed. Closing PR #22503 and removing active labels.