Bug 266635 - [IFC][Ruby] Anonymous bases should have white-space:nowrap
Summary: [IFC][Ruby] Anonymous bases should have white-space:nowrap
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-12-19 06:28 PST by Antti Koivisto
Modified: 2023-12-19 12:08 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2023-12-19 06:28:54 PST 
The default UA stylesheet has 'whitespace: no-wrap' for bases. This should also be applied to the anonymous ones.
Comment 1 Radar WebKit Bug Importer 2023-12-19 06:29:10 PST 
<rdar://problem/119864996>
Comment 2 Ahmad Saleem 2023-12-19 06:34:53 PST 
@Antti - I have one separate bug 265316 to sync 'ruby.css' with latest web-spec. Should we do all and clean-up 'html.css' one?

Or you want to tackle one by one these UA rules.
Comment 3 Antti Koivisto 2023-12-19 06:39:13 PST 
Pull request: https://github.com/WebKit/WebKit/pull/22025
Comment 4 Antti Koivisto 2023-12-19 10:34:23 PST 
(In reply to Ahmad Saleem from comment #2)
> @Antti - I have one separate bug 265316 to sync 'ruby.css' with latest
> web-spec. Should we do all and clean-up 'html.css' one?
> 
> Or you want to tackle one by one these UA rules.

I think we'll eventually move ruby stuff to html.css. Meanwhile syncing it is a good activity but better done one property at a time and with tests.

I had line-height:1 there for a bit but reverted it to ease the transition.
Comment 5 EWS 2023-12-19 12:08:13 PST 
Committed 272285@main (bcdeb1ae72eb): <https://commits.webkit.org/272285@main>

Reviewed commits have been landed. Closing PR #22025 and removing active labels.