Bug 26662 – hover over table rows causes the whole table to repaint

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Ojan Vafai]

Test case coming.

[Ojan Vafai]

Created attachment 31737 [details]
Test case

Load this test case and hover over the rows with QuartzDebug. The whole table repaints.

[Ojan Vafai]

dhyatt: IntRect RenderTableRow::clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer)
dhyatt: {
dhyatt:     // For now, just repaint the whole table.
dhyatt:     // FIXME: Find a better way to do this, e.g., need to repaint all the cells that we
dhyatt:     // might have propagated a background color into.
dhyatt: RenderTableRow.cpp
dhyatt: ojan: it's basically not that hard to fix... just spanning cell issue
dhyatt: ojan: can't just naively invalidate only the row
dhyatt: since the bgcolor of the row may be painted in a spanning cell
[SNIP]
dhyatt: ojan: it is lame
dhyatt: ojan: should be fixed

[Dave Hyatt]

Created attachment 241066 [details]
Patch

Patch just for EWS.

[Build Bot]

Created attachment 241072 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Created attachment 241077 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Dave Hyatt]

Created attachment 241353 [details]
Patch

[Dean Jackson]

Comment on attachment 241353 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241353&action=review

> Source/WebCore/rendering/RenderTableCell.h:220
> +    virtual LayoutRect clippedOverflowRectForRepaint(const RenderLayerModelObject* repaintContainer) const override;

Did you mean to move this....

> Source/WebCore/rendering/RenderTableCell.h:-238
> -    virtual LayoutRect clippedOverflowRectForRepaint(const RenderLayerModelObject* repaintContainer) const override;

... from here?

[Simon Fraser (smfr)]

Comment on attachment 241353 [details]
Patch

Please make a test that dumps repaint rects instead.

[Dave Hyatt]

Created attachment 241429 [details]
Patch

[Dave Hyatt]

Fixed in r176124.