Bug 26656 - [Chromium] Fix crash with inherited font-size in <option>
: [Chromium] Fix crash with inherited font-size in <option>
Status: RESOLVED FIXED
: WebKit
Layout and Rendering
: 528+ (Nightly build)
: PC All
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2009-06-23 13:22 PST by
Modified: 2009-06-24 14:11 PST (History)


Attachments
patch (2.12 KB, patch)
2009-06-23 13:23 PST, Adam Langley
no flags Review Patch | Details | Formatted Diff | Diff
patch (2.12 KB, patch)
2009-06-23 13:25 PST, Adam Langley
eric: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-06-23 13:22:34 PST
In r42597 (https://bugs.webkit.org/show_bug.cgi?id=25244), I changed the <select> handing for Chromium to fix a rendering bug. However, although the font-size is correctly ignored, getRowHeight wasn't updated and so was calculating the height of the rows in an inconsistent manner. This can lead to a crash.

http://code.google.com/p/chromium/issues/detail?id=14810
------- Comment #1 From 2009-06-23 13:23:53 PST -------
Created an attachment (id=31729) [details]
patch
------- Comment #2 From 2009-06-23 13:25:52 PST -------
Created an attachment (id=31730) [details]
patch

Wrong bug link, should be http://code.google.com/p/chromium/issues/detail?id=14853
------- Comment #3 From 2009-06-23 17:40:33 PST -------
(From update of attachment 31730 [details])
If you're intending the test change to test the crash, you need to add a comment to both the test and the ChangeLog.  Since you're a committer, you can do that when you land.

Is it not possible to test this change with LayoutTest instead of a manual-test?
------- Comment #4 From 2009-06-23 19:34:23 PST -------
> Is it not possible to test this change with LayoutTest instead of a
> manual-test?

I tried all manner of window.eventSender ticks to try and get it to trigger the crash, but none of them worked. Testing doesn't work very well with <selects>.