Bug 266481 - Stop using CheckedPtr with ChildNodeList / EmptyNodeList
Summary: Stop using CheckedPtr with ChildNodeList / EmptyNodeList
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-12-15 07:48 PST by Chris Dumez
Modified: 2023-12-15 09:43 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2023-12-15 07:48:54 PST 
Stop using CheckedPtr with ChildNodeList / EmptyNodeList. Use WeakPtr instead to generate more actionable crashes.
This tested as performance neutral on Speedometer 2 & 3.
Comment 1 Chris Dumez 2023-12-15 07:50:12 PST 
Pull request: https://github.com/WebKit/WebKit/pull/21866
Comment 2 EWS 2023-12-15 09:42:10 PST 
Committed 272123@main (d6daeabfcd1e): <https://commits.webkit.org/272123@main>

Reviewed commits have been landed. Closing PR #21866 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-12-15 09:43:16 PST 
<rdar://problem/119725581>