WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
266465
ASSERTION FAILED: isStartOfParagraph(startOfParagraphToMove) in imported/w3c/web-platform-tests/editing/run/delete.html?6001-7000
https://bugs.webkit.org/show_bug.cgi?id=266465
Summary
ASSERTION FAILED: isStartOfParagraph(startOfParagraphToMove) in imported/w3c/...
Vitaly Dyackhov
Reported
2023-12-15 01:28:10 PST
The subtest causing this assertion to fail: ``` ["<span style=display:inline-table>fo[o</span><span style=display:inline-table>b]ar</span>", [["delete",""]], "<span style=\"display:inline-table\">fo[]</span><span style=\"display:inline-table\">ar</span>", [true], {"delete":[false,false,"",false,false,""]}], ``` in `LayoutTests/imported/w3c/web-platform-tests/editing/data/delete.js` Stack trace: ``` #0 WTFCrash() () at /app/webkit/Source/WTF/wtf/Assertions.cpp:333 #1 0x00007f62f465a115 in WTFCrashWithInfo(int, char const*, char const*, int) () at /app/webkit/WebKitBuild/GTK/Debug/WTF/Headers/wtf/Assertions.h:778 #2 0x00007f62f95b133b in WebCore::CompositeEditCommand::moveParagraph(WebCore::VisiblePosition const&, WebCore::VisiblePosition const&, WebCore::VisiblePosition const&, bool, bool) (this=0x7f6006892480, startOfParagraphToMove=..., endOfParagraphToMove=..., destination=..., preserveSelection=false, preserveStyle=true) at /app/webkit/Source/WebCore/editing/CompositeEditCommand.cpp:1444 #3 0x00007f62f95cbb01 in WebCore::DeleteSelectionCommand::mergeParagraphs() (this=0x7f6006892480) at /app/webkit/Source/WebCore/editing/DeleteSelectionCommand.cpp:850 #4 0x00007f62f95ccdba in WebCore::DeleteSelectionCommand::doApply() (this=0x7f6006892480) at /app/webkit/Source/WebCore/editing/DeleteSelectionCommand.cpp:1038 #5 0x00007f62f95aa7c6 in WebCore::CompositeEditCommand::applyCommandToComposite(WTF::Ref<WebCore::EditCommand, WTF::RawPtrTraits<WebCore::EditCommand> >&&) (this=0x7f6033cd4e80, command=...) at /app/webkit/Source/WebCore/editing/CompositeEditCommand.cpp:498 #6 0x00007f62f95ad5ec in WebCore::CompositeEditCommand::deleteSelection(WebCore::VisibleSelection const&, bool, bool, bool, bool, bool) (this=0x7f6033cd4e80, selection=..., smartDelete=false, mergeBlocksAfterDelete=true, replace=false, expandForSpecialElements=true, sanitizeMarkup=true) at /app/webkit/Source/WebCore/editing/CompositeEditCommand.cpp:874 #7 0x00007f62f967eb43 in WebCore::TypingCommand::deleteKeyPressed(WebCore::TextGranularity, bool) (this=0x7f6033cd4e80, granularity=WebCore::TextGranularity::CharacterGranularity, shouldAddToKillRing=false) at /app/webkit/Source/WebCore/editing/TypingCommand.cpp:766 #8 0x00007f62f967c528 in WebCore::TypingCommand::doApply() (this=0x7f6033cd4e80) at /app/webkit/Source/WebCore/editing/TypingCommand.cpp:374 #9 0x00007f62f95aa037 in WebCore::CompositeEditCommand::apply() (this=0x7f6033cd4e80) at /app/webkit/Source/WebCore/editing/CompositeEditCommand.cpp:402 #10 0x00007f62f967b507 in WebCore::TypingCommand::deleteKeyPressed(WTF::Ref<WebCore::Document, WTF::RawPtrTraits<WebCore::Document> >&&, WTF::OptionSet<WebCore::TypingCommand::Option>, WebCore::TextGranularity) (document=..., options=..., granularity=WebCore::TextGranularity::CharacterGranularity) at /app/webkit/Source/WebCore/editing/TypingCommand.cpp:195 #11 0x00007f62f9603c27 in WebCore::executeDelete(WebCore::LocalFrame&, WebCore::Event*, WebCore::EditorCommandSource, WTF::String const&) (frame=..., source=WebCore::EditorCommandSource::DOM) at /app/webkit/Source/WebCore/editing/EditorCommand.cpp:301 #12 0x00007f62f96098f0 in WebCore::Editor::Command::execute(WTF::String const&, WebCore::Event*) const (this=0x7ffc3f2e1c80, parameter=..., triggeringEvent=0x0) at /app/webkit/Source/WebCore/editing/EditorCommand.cpp:1925 #13 0x00007f62f927a741 in WebCore::Document::execCommand(WTF::String const&, bool, WTF::String const&) (this=0x7f602d344000, commandName=..., userInterface=false, value=...) at /app/webkit/Source/WebCore/dom/Document.cpp:6409 #14 0x00007f62f6a16622 in WebCore::jsDocumentPrototypeFunction_execCommandBody(JSC::JSGlobalObject*, JSC::CallFrame*, WebCore::IDLOperation<WebCore::JSDocument>::ClassParameter) (lexicalGlobalObject=0x7f6031737260, callFrame=0x7ffc3f2e1eb0, castedThis=0x7f6291e24fa0) at /app/webkit/WebKitBuild/GTK/Debug/WebCore/DerivedSources/JSDocument.cpp:6475 #15 0x00007f62f6a3f08f in WebCore::IDLOperation<WebCore::JSDocument>::call<WebCore::jsDocumentPrototypeFunction_execCommandBody>(JSC::JSGlobalObject&, JSC::CallFrame&, char const*) (lexicalGlobalObject=..., callFrame=..., operationName=0x7f62ed7d8c27 "execCommand") at /app/webkit/Source/WebCore/bindings/js/JSDOMOperation.h:63 #16 0x00007f62f6a16703 in WebCore::jsDocumentPrototypeFunction_execCommand(JSC::JSGlobalObject*, JSC::CallFrame*) (lexicalGlobalObject=0x7f6031737260, callFrame=0x7ffc3f2e1eb0) at /app/webkit/WebKitBuild/GTK/Debug/WebCore/DerivedSources/JSDocument.cpp:6480 #17 0x00007f6294008038 in () #18 0x00007ffc3f2e1f50 in () #19 0x00007f629467fc53 in () #20 0x0000000000000000 in () ```
Attachments
Add attachment
proposed patch, testcase, etc.
Vitaly Dyackhov
Comment 1
2023-12-15 01:40:07 PST
Pull request:
https://github.com/WebKit/WebKit/pull/21854
EWS
Comment 2
2023-12-15 01:43:17 PST
Test gardening commit
272104@main
(0826b15031a1): <
https://commits.webkit.org/272104@main
> Reviewed commits have been landed. Closing PR #21854 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2023-12-22 01:29:12 PST
<
rdar://problem/120036108
>
EWS
Comment 4
2024-08-30 06:36:50 PDT
Committed
282962@main
(ae3c1353c144): <
https://commits.webkit.org/282962@main
> Reviewed commits have been landed. Closing PR #32817 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug