Bug 266416 - Use CheckedPtr<Node> less for non-stack objects
Summary: Use CheckedPtr<Node> less for non-stack objects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-12-14 09:06 PST by Chris Dumez
Modified: 2023-12-14 15:45 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2023-12-14 09:06:13 PST 
Use CheckedPtr<Node> less for non-stack objects. Use WeakPtr<Node> instead in order to generate more actionable crashes.
This tested as performance neutral on Speedometer 2 & 3.
Comment 1 Chris Dumez 2023-12-14 09:07:49 PST 
Pull request: https://github.com/WebKit/WebKit/pull/21803
Comment 2 Radar WebKit Bug Importer 2023-12-14 09:19:19 PST 
<rdar://problem/119671407>
Comment 3 EWS 2023-12-14 15:45:38 PST 
Committed 272079@main (573543334088): <https://commits.webkit.org/272079@main>

Reviewed commits have been landed. Closing PR #21803 and removing active labels.