Bug 26640 - JSON.stringify needs to special case Boolean objects
: JSON.stringify needs to special case Boolean objects
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore
: 528+ (Nightly build)
: Macintosh Mac OS X 10.5
: P2 Normal
Assigned To: Oliver Hunt
:
Depends on:
Blocks: 26249
  Show dependency treegraph
 
Reported: 2009-06-22 22:08 PDT by Oliver Hunt
Modified: 2009-06-22 22:45 PDT (History)
0 users

See Also:


Attachments
Special case Boolean (8.80 KB, patch)
2009-06-22 22:34 PDT, Oliver Hunt
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2009-06-22 22:08:09 PDT
Boolean is special cased alongside Number and String objects now (http://wiki.ecmascript.org/lib/exe/fetch.php?id=es3.1%3Aes3.1_proposal_working_draft&cache=cache&media=es3.1:es5_candidate_errata_june_17.pdf)
Comment 1 Oliver Hunt 2009-06-22 22:34:58 PDT
Created attachment 31705 [details]
Special case Boolean
Comment 2 Alexey Proskuryakov 2009-06-22 22:42:31 PDT
Comment on attachment 31705 [details]
Special case Boolean

r=me. LayoutTests/ChangeLog should mention that you added other primitive tests, not just booleans.
Comment 3 Oliver Hunt 2009-06-22 22:45:30 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	JavaScriptCore/ChangeLog
	M	JavaScriptCore/runtime/JSONObject.cpp
	M	LayoutTests/ChangeLog
	M	LayoutTests/fast/js/JSON-stringify-expected.txt
	M	LayoutTests/fast/js/resources/JSON-stringify.js
	M	LayoutTests/fast/js/resources/json2-es5-compat.js
Committed r44974