Bug 266384 – AX: aria-labeledby should be ignored for browser interop reasons.

• Status: NEW
• Component: Accessibility

[Andres Gonzalez]

Only aria-labelledby should be used instead.

[Radar WebKit Bug Importer]

<rdar://problem/119640762>

[Andres Gonzalez]

Created attachment 469031 [details]
Patch

[Andres Gonzalez]

Created attachment 469039 [details]
Patch

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[Andres Gonzalez]

Created attachment 469040 [details]
Patch

[Andres Gonzalez]

Created attachment 469046 [details]
Patch

[Andres Gonzalez]

Created attachment 469051 [details]
Patch

[Tyler Wilcock]

Comment on attachment 469051 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=469051&action=review

> LayoutTests/accessibility/aria-labelledby-overrides-aria-label-expected.txt:6
> +usingLabel.title: [AXTitle: ]

Why is this testcase affected by removing aria-labeledby? It was just using its button innner-text with an aria-label, no aria-labelledby or labeledby as far as I can tell.

> LayoutTests/accessibility/aria-labelledby-overrides-aria-label-expected.txt:8
> +usingLabelledby.title: [AXTitle: ]

As the correct-spelling version, shouldn't this still have a title?

[Andres Gonzalez]

(In reply to Tyler Wilcock from comment #8)
> Comment on attachment 469051 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=469051&action=review
> 
> > LayoutTests/accessibility/aria-labelledby-overrides-aria-label-expected.txt:6
> > +usingLabel.title: [AXTitle: ]
> 
> Why is this testcase affected by removing aria-labeledby? It was just using
> its button innner-text with an aria-label, no aria-labelledby or labeledby
> as far as I can tell.
> 
> > LayoutTests/accessibility/aria-labelledby-overrides-aria-label-expected.txt:8
> > +usingLabelledby.title: [AXTitle: ]
> 
> As the correct-spelling version, shouldn't this still have a title?

The accessibility/*-expected.txt wasn't being used because there was one for platform/Mac and one for platform/glib. So what I did was to remove the one from platform/Mac and move it to accessibility, as we do with most other tests, i.e., the Mac expectation file is in the accessibility dir and other platforms if differ are int heir corresponding platform/ dirs. So if you compare the new accessibility/*-expected.txt with the deleted platform/Mac one, you can confirm that the only change is the removal of the labeledby lines. Thanks for being alert about these changes.

[Tyler Wilcock]

(In reply to Andres Gonzalez from comment #9)
> (In reply to Tyler Wilcock from comment #8)
> > Comment on attachment 469051 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=469051&action=review
> > 
> > > LayoutTests/accessibility/aria-labelledby-overrides-aria-label-expected.txt:6
> > > +usingLabel.title: [AXTitle: ]
> > 
> > Why is this testcase affected by removing aria-labeledby? It was just using
> > its button innner-text with an aria-label, no aria-labelledby or labeledby
> > as far as I can tell.
> > 
> > > LayoutTests/accessibility/aria-labelledby-overrides-aria-label-expected.txt:8
> > > +usingLabelledby.title: [AXTitle: ]
> > 
> > As the correct-spelling version, shouldn't this still have a title?
> 
> The accessibility/*-expected.txt wasn't being used because there was one for
> platform/Mac and one for platform/glib. So what I did was to remove the one
> from platform/Mac and move it to accessibility, as we do with most other
> tests, i.e., the Mac expectation file is in the accessibility dir and other
> platforms if differ are int heir corresponding platform/ dirs. So if you
> compare the new accessibility/*-expected.txt with the deleted platform/Mac
> one, you can confirm that the only change is the removal of the labeledby
> lines. Thanks for being alert about these changes.
Oh right, should've noticed that, thanks!

[Tyler Wilcock]

Comment on attachment 469051 [details]
Patch

Changing to r- as the misspelling is used by too many sites to remove for now.

[James Craig]

More info on that here: 
- https://github.com/w3c/aria/issues/2093