Bug 266359 - [ews] revert-pull-request-changes step does not appear to delete the build directory
Summary: [ews] revert-pull-request-changes step does not appear to delete the build di...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-12-13 12:00 PST by Elliott Williams
Modified: 2024-02-13 12:12 PST (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Williams 2023-12-13 12:00:02 PST 
In builds like https://ews-build.webkit.org/#/builders/14/builds/31777, I see it running `git clean -f -d` only, which is not enough to delete the WebKitBuild directory, since it's gitignore'd.
Comment 1 Radar WebKit Bug Importer 2023-12-20 12:00:13 PST 
<rdar://problem/119947440>
Comment 2 Aakash Jain 2024-02-13 11:32:36 PST 
In patch workflow we run the step UnApplyPatch which runs Tools/Scripts/clean-webkit. Whereas in PR workflow we run RevertPullRequestChanges step which run this git clean command.

I wonder in PR workflow, we un-intentionally stopped doing proper clean build.

Note that the same UnApplyPatch wasn't used in PR workflow for reason mentioned in https://bugs.webkit.org/show_bug.cgi?id=235825#c0 , but maybe we can have both UnApplyPatch as well as RevertPullRequestChanges step in PR workflow.
Comment 3 Aakash Jain 2024-02-13 11:34:54 PST 
> both UnApplyPatch as well as RevertPullRequestChanges
I mean both CleanWorkingDirectory and RevertPullRequestChanges steps.