RESOLVED FIXED266359
[ews] revert-pull-request-changes step does not appear to delete the build directory 
https://bugs.webkit.org/show_bug.cgi?id=266359
Summary [ews] revert-pull-request-changes step does not appear to delete the build di...
Elliott Williams
Reported 2023-12-13 12:00:02 PST
In builds like https://ews-build.webkit.org/#/builders/14/builds/31777, I see it running `git clean -f -d` only, which is not enough to delete the WebKitBuild directory, since it's gitignore'd.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-12-20 12:00:13 PST
<rdar://problem/119947440>
Aakash Jain
Comment 2 2024-02-13 11:32:36 PST
In patch workflow we run the step UnApplyPatch which runs Tools/Scripts/clean-webkit. Whereas in PR workflow we run RevertPullRequestChanges step which run this git clean command. I wonder in PR workflow, we un-intentionally stopped doing proper clean build. Note that the same UnApplyPatch wasn't used in PR workflow for reason mentioned in https://bugs.webkit.org/show_bug.cgi?id=235825#c0 , but maybe we can have both UnApplyPatch as well as RevertPullRequestChanges step in PR workflow.
Aakash Jain
Comment 3 2024-02-13 11:34:54 PST
> both UnApplyPatch as well as RevertPullRequestChanges I mean both CleanWorkingDirectory and RevertPullRequestChanges steps.
Jonathan Bedard
Comment 4 2024-05-10 15:13:47 PDT
I didn't realize we intended to delete the WebKitBuild directory, in this circumstance.
Jonathan Bedard
Comment 5 2024-05-10 15:25:20 PDT
Pull request: https://github.com/WebKit/WebKit/pull/28412
EWS
Comment 6 2024-05-13 08:28:04 PDT
Committed 278689@main (55a78ab59e0a): <https://commits.webkit.org/278689@main> Reviewed commits have been landed. Closing PR #28412 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.