Bug 266357 - [IFC][Ruby] Incorrect preferred width computation when <ruby> is present
Summary: [IFC][Ruby] Incorrect preferred width computation when <ruby> is present
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-12-13 10:40 PST by zalan
Modified: 2023-12-13 15:45 PST (History)
11 users (show)

See Also:

Attachments
Patch (4.89 KB, patch)
2023-12-13 10:53 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (4.88 KB, patch)
2023-12-13 11:00 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (6.84 KB, patch)
2023-12-13 12:29 PST, zalan 		no flags Details | Formatted Diff | Diff
[fast-cq]Patch (6.92 KB, patch)
2023-12-13 12:36 PST, zalan 		no flags Details | Formatted Diff | Diff
[fast-cq]Patch (6.92 KB, patch)
2023-12-13 15:26 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2023-12-13 10:40:14 PST 
ssia
Comment 1 zalan 2023-12-13 10:53:53 PST 
Created attachment 469019 [details]
Patch
Comment 2 Antti Koivisto 2023-12-13 10:57:15 PST 
Comment on attachment 469019 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=469019&action=review

> Source/WebCore/rendering/RenderBlockFlow.cpp:4704
> +                        rubyBaseMinimumMaximumWidthStack.append(std::make_pair(inlineMin, inlineMax));

I think you can alternatively just say std::pair {  inlineMin, inlineMax }, make_pair is not necessary anymore.
Comment 3 zalan 2023-12-13 11:00:53 PST 
Created attachment 469021 [details]
Patch
Comment 4 zalan 2023-12-13 12:29:02 PST 
Created attachment 469022 [details]
Patch
Comment 5 zalan 2023-12-13 12:36:55 PST 
Created attachment 469023 [details]
[fast-cq]Patch
Comment 6 zalan 2023-12-13 15:26:53 PST 
Created attachment 469027 [details]
[fast-cq]Patch
Comment 7 EWS 2023-12-13 15:44:47 PST 
Committed 272011@main (fcb3a49fe8cd): <https://commits.webkit.org/272011@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 469027 [details].
Comment 8 Radar WebKit Bug Importer 2023-12-13 15:45:17 PST 
<rdar://problem/119634971>