WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
266274
Remove ControlStates::State in favor of ControlStyle::State
https://bugs.webkit.org/show_bug.cgi?id=266274
Summary
Remove ControlStates::State in favor of ControlStyle::State
Anne van Kesteren
Reported
2023-12-12 02:22:32 PST
Unlike RenderTheme::extractControlStyleForRenderer(), RenderTheme::extractControlStatesForRenderer() does not account for shadow host ancestors. The latter also essentially duplicates the exact functionality. This almost caused a problem for iOS switch controls which happen to use the latter, but they only rely on a state which happens to be shared. Still, that will not last forever so we need to address this.
Attachments
Add attachment
proposed patch, testcase, etc.
Anne van Kesteren
Comment 1
2023-12-14 07:41:52 PST
Pull request:
https://github.com/WebKit/WebKit/pull/21797
EWS
Comment 2
2023-12-15 03:16:47 PST
Committed
272106@main
(f93441ff7ade): <
https://commits.webkit.org/272106@main
> Reviewed commits have been landed. Closing PR #21797 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2023-12-15 03:17:15 PST
<
rdar://problem/119713966
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug