WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
266199
[WTF] Distinguish SerialFunctionDispatcher that are refcounted
https://bugs.webkit.org/show_bug.cgi?id=266199
Summary
[WTF] Distinguish SerialFunctionDispatcher that are refcounted
Jean-Yves Avenard [:jya]
Reported
2023-12-10 17:20:34 PST
Right now, SerialFunctionDispatcher is designed to have an explicit lifetime. All SerialFunctionDispatcher but one are currently ref counted. We need to be able to easily determine if a SerialFunctionDispatcher is refounted by having a RefCountedSerialFunctionDispatcher This change isn't aimed at resolving the SerialFunctionDispatcher API contact, which is there's no guarantee currently that the dispatched runnable will actually be run and that the SerialFunctionDispatcher got shutdown. RefCountedSerialFunctionDispatcher is just about enforcing the lifetime of the object, not the lifetime of the API contract.
Attachments
Add attachment
proposed patch, testcase, etc.
Jean-Yves Avenard [:jya]
Comment 1
2023-12-10 21:14:54 PST
Correction: RefCountedSerialFunctionDispatcher will enforce that the function dispatched is guaranteed to run.
Radar WebKit Bug Importer
Comment 2
2023-12-10 21:17:38 PST
<
rdar://problem/119476929
>
Jean-Yves Avenard [:jya]
Comment 3
2023-12-10 21:17:45 PST
<
rdar://problem/119476929
>
Jean-Yves Avenard [:jya]
Comment 4
2023-12-10 21:22:43 PST
Pull request:
https://github.com/WebKit/WebKit/pull/21617
EWS
Comment 5
2023-12-11 01:20:54 PST
Committed
271860@main
(cfe5a3b9ba53): <
https://commits.webkit.org/271860@main
> Reviewed commits have been landed. Closing PR #21617 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug