WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
26616
invalid unsigned type in SharedTimerWx.cpp
https://bugs.webkit.org/show_bug.cgi?id=26616
Summary
invalid unsigned type in SharedTimerWx.cpp
Kevin Watters
Reported
2009-06-22 11:21:56 PDT
The intervalInMS variable in SharedTimerWx.cpp's setSharedTimerFireTime functions is unsigned, but it can be negative when other code sets fireTime to be currentTime(). We need to prevent integer underflow here and make the variable signed.
Attachments
make intervalInMS signed
(1021 bytes, patch)
2009-06-22 11:22 PDT
,
Kevin Watters
kevino
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kevin Watters
Comment 1
2009-06-22 11:22:27 PDT
Created
attachment 31658
[details]
make intervalInMS signed
Eric Seidel (no email)
Comment 2
2009-06-24 00:47:29 PDT
Committing to
http://svn.webkit.org/repository/webkit/trunk
... M WebCore/ChangeLog M WebCore/platform/wx/SharedTimerWx.cpp Committed
r45070
http://trac.webkit.org/changeset/45070
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug