RESOLVED FIXED26612
Notify of profile start in console 
https://bugs.webkit.org/show_bug.cgi?id=26612
Summary Notify of profile start in console
Kevin McCullough
Reported 2009-06-22 10:57:58 PDT
We should notify users in the console of a profile starting and stopping. Currently we only notify when the profile has finished. <rdar://problem/6115819> Notify of profile start in console
Attachments
proposed patch (5.33 KB, patch)
2009-06-22 10:58 PDT, Kevin McCullough 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kevin McCullough
Comment 1 2009-06-22 10:58:56 PDT
Created attachment 31656 [details] proposed patch
Darin Adler
Comment 2 2009-06-22 11:28:02 PDT
Comment on attachment 31656 [details] proposed patch > - void addProfileMessageToConsole(PassRefPtr<JSC::Profile> prpProfile, unsigned lineNumber, const JSC::UString& sourceURL); > + void addProfileFinishedMessageToConsole(PassRefPtr<JSC::Profile> prpProfile, unsigned lineNumber, const JSC::UString& sourceURL); Should omit the name prpProfile here. > void addScriptProfile(JSC::Profile* profile); And the name profile here. > const ProfilesArray& profiles() const { return m_profiles; } > > + // The title is used in the console message announcing that a profile has started so it get's No apostrophe needed in gets. r=me
Kevin McCullough
Comment 3 2009-06-22 11:51:39 PDT
Committed revision 44947.
Note You need to log in before you can comment on or make changes to this bug.