Bug 266080 - Introduce compile-time checks and alternate allocation paths for compact pointer types
Summary: Introduce compile-time checks and alternate allocation paths for compact poin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Degazio
URL:
Keywords: InRadar
Depends on: 266140
Blocks:
  Show dependency treegraph
 
Reported: 2023-12-08 10:10 PST by David Degazio
Modified: 2023-12-19 14:54 PST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Degazio 2023-12-08 10:10:23 PST
rdar://119382681

Currently, we make the call for whether packed and compact pointer representations are usable based on the global EFFECTIVE_ADDRESS_WIDTH constant; instead, it might be desirable for us move towards finer-grained enablement of these optimizations, specifically being able to enable them on a type-by-type basis.

As a first step, let's:
 - Require types to opt-into compact pointer usage, instead of assuming all pointers can be compacted/packed in the same way.
 - Add alternate allocator paths for types that are used in compact pointers, giving us a new API point to control how they are allocated in the future.
Comment 1 David Degazio 2023-12-08 10:54:59 PST
Pull request: https://github.com/WebKit/WebKit/pull/21517
Comment 2 EWS 2023-12-09 00:33:09 PST
Committed 271796@main (27959d8049ad): <https://commits.webkit.org/271796@main>

Reviewed commits have been landed. Closing PR #21517 and removing active labels.
Comment 3 WebKit Commit Bot 2023-12-09 03:09:47 PST
Re-opened since this is blocked by bug 266140
Comment 4 David Degazio 2023-12-09 09:55:42 PST
Pull request: https://github.com/WebKit/WebKit/pull/21576
Comment 5 EWS 2023-12-09 17:53:44 PST
Committed 271819@main (2c04bdef5846): <https://commits.webkit.org/271819@main>

Reviewed commits have been landed. Closing PR #21576 and removing active labels.