Bug 26607 - Implement IDL interface for datagrid rows
Summary: Implement IDL interface for datagrid rows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks: 26546
  Show dependency treegraph
 
Reported: 2009-06-22 09:21 PDT by Dave Hyatt
Modified: 2009-06-22 09:34 PDT (History)
0 users

See Also:


Attachments
Patch (25.31 KB, patch)
2009-06-22 09:22 PDT, Dave Hyatt
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2009-06-22 09:21:27 PDT
Interface for row elements.
Comment 1 Dave Hyatt 2009-06-22 09:22:22 PDT
Created attachment 31650 [details]
Patch
Comment 2 Sam Weinig 2009-06-22 09:28:19 PDT
Comment on attachment 31650 [details]
Patch

> Index: ChangeLog
> ===================================================================
> --- ChangeLog	(revision 44935)
> +++ ChangeLog	(working copy)
> @@ -1,3 +1,38 @@
> +2009-06-22  David Hyatt  <hyatt@apple.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        WARNING: NO TEST CASES ADDED OR CHANGED


Some changelogy goodness please.


> +
> +#ifndef HTMLDataGridRowElement_h
> +#define HTMLDataGridRowElement_h
> +
> +#include "HTMLElement.h"
> +
> +namespace WebCore {
> +
> +class HTMLDataGridRowElement : public HTMLElement
> +{

{ should go on the previous line.

> +public:
> +    HTMLDataGridRowElement(const QualifiedName&, Document*);
> +
> +    virtual int tagPriority() const { return 2; } // Same as <option>s.
> +    
> +    bool selected() const;
> +    void setSelected(bool);
> +    
> +    bool focused() const;
> +    void setFocused(bool);
> +};
> +
> +} //namespace

should be // namespace WebCore

> +
> +#endif

We like to add #endif // HTMLDataGridRowElement_h

r=me with these cleanups.
Comment 3 Dave Hyatt 2009-06-22 09:34:35 PDT
Fixed in r44937.