WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
26607
Implement IDL interface for datagrid rows
https://bugs.webkit.org/show_bug.cgi?id=26607
Summary
Implement IDL interface for datagrid rows
Dave Hyatt
Reported
2009-06-22 09:21:27 PDT
Interface for row elements.
Attachments
Patch
(25.31 KB, patch)
2009-06-22 09:22 PDT
,
Dave Hyatt
sam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dave Hyatt
Comment 1
2009-06-22 09:22:22 PDT
Created
attachment 31650
[details]
Patch
Sam Weinig
Comment 2
2009-06-22 09:28:19 PDT
Comment on
attachment 31650
[details]
Patch
> Index: ChangeLog > =================================================================== > --- ChangeLog (revision 44935) > +++ ChangeLog (working copy) > @@ -1,3 +1,38 @@ > +2009-06-22 David Hyatt <
hyatt@apple.com
> > + > + Reviewed by NOBODY (OOPS!). > + > + WARNING: NO TEST CASES ADDED OR CHANGED
Some changelogy goodness please.
> + > +#ifndef HTMLDataGridRowElement_h > +#define HTMLDataGridRowElement_h > + > +#include "HTMLElement.h" > + > +namespace WebCore { > + > +class HTMLDataGridRowElement : public HTMLElement > +{
{ should go on the previous line.
> +public: > + HTMLDataGridRowElement(const QualifiedName&, Document*); > + > + virtual int tagPriority() const { return 2; } // Same as <option>s. > + > + bool selected() const; > + void setSelected(bool); > + > + bool focused() const; > + void setFocused(bool); > +}; > + > +} //namespace
should be // namespace WebCore
> + > +#endif
We like to add #endif // HTMLDataGridRowElement_h r=me with these cleanups.
Dave Hyatt
Comment 3
2009-06-22 09:34:35 PDT
Fixed in
r44937
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug