Bug 26604 - Search doesn't work in Web Inspector Profiler
Summary: Search doesn't work in Web Inspector Profiler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-22 04:24 PDT by Mikhail Naganov
Modified: 2009-06-24 18:53 PDT (History)
3 users (show)

See Also:

Attachments
Proposed patch (5.66 KB, patch)
2009-06-22 04:51 PDT, Mikhail Naganov 		no flags Details | Formatted Diff | Diff
Proposed patch, replaced tabs with spaces in ChangeLog (5.72 KB, patch)
2009-06-24 00:14 PDT, Mikhail Naganov 		timothy: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Naganov 2009-06-22 04:24:23 PDT 
To reproduce:

- create a profiler report;
- try to search something existing using the "Search Profiles" input box, e.g. search for a "(program)";
- Inspector will show matches count, but will not allow you to jump to the next result;
- now try to search something non-existing, e.g. "not here";
- Inspector will show the same matches count, and also will not jump to the next result.

Tested on nightly revision 44932.
Comment 1 Mikhail Naganov 2009-06-22 04:51:13 PDT 
Created attachment 31644 [details]
Proposed patch
Comment 2 Eric Seidel (no email) 2009-06-23 17:56:47 PDT 
Comment on attachment 31644 [details]
Proposed patch

Tabs in your ChangeLog.  Tim is the man to review this I think.
Comment 3 Mikhail Naganov 2009-06-24 00:14:17 PDT 
Created attachment 31771 [details]
Proposed patch, replaced tabs with spaces in ChangeLog
Comment 4 Eric Seidel (no email) 2009-06-24 18:53:01 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/ProfileView.js
Committed r45131
http://trac.webkit.org/changeset/45131