Bug 266034 - REGRESSION(271529@main): Volatility timer stops before all surfaces are made volatile and never completes.
Summary: REGRESSION(271529@main): Volatility timer stops before all surfaces are made ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Woodrow
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-12-07 16:19 PST by Matt Woodrow
Modified: 2023-12-07 18:08 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Woodrow 2023-12-07 16:19:58 PST 
If `identifiers` is empty it means we didn't collect any right now, not that there weren't any to be collected.

We should only stop the timer if `collectedAllRemoteRenderingBuffers` is true (as well as `successfullyMadeBackingStoreVolatile`).
Comment 1 Radar WebKit Bug Importer 2023-12-07 16:20:13 PST 
<rdar://problem/119344111>
Comment 2 Matt Woodrow 2023-12-07 16:22:37 PST 
Pull request: https://github.com/WebKit/WebKit/pull/21477
Comment 3 EWS 2023-12-07 18:08:43 PST 
Committed 271704@main (052b3e14ae00): <https://commits.webkit.org/271704@main>

Reviewed commits have been landed. Closing PR #21477 and removing active labels.