Bug 26601 - Remove disabled code for appcache dynamic entries
Summary: Remove disabled code for appcache dynamic entries
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-22 01:43 PDT by Alexey Proskuryakov
Modified: 2009-06-22 11:23 PDT (History)
0 users

See Also:


Attachments
proposed patch (52.29 KB, patch)
2009-06-22 01:47 PDT, Alexey Proskuryakov
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2009-06-22 01:43:06 PDT
We still have some unfinished code for application cache dynamic entries in trunk. It is based on DOMStringList code that we don't use anywhere else (even though it is used elsewhere in DOM 3 Core and in HTML5), which should probably be removed for now, as well.
Comment 1 Alexey Proskuryakov 2009-06-22 01:47:39 PDT
Created attachment 31639 [details]
proposed patch
Comment 2 Darin Adler 2009-06-22 08:38:02 PDT
Comment on attachment 31639 [details]
proposed patch

Diff seems to be confused about ApplicationCacheGroup.cpp. I see diffs there in code that hasn't changed at all.

r=me
Comment 3 Alexey Proskuryakov 2009-06-22 11:23:25 PDT
(In reply to comment #2)
> Diff seems to be confused about ApplicationCacheGroup.cpp. I see diffs there in
> code that hasn't changed at all.

Turns out Xcode corrected line endings there. Appcache files were missing svn:eol-style properties, which I now added.