Bug 266008 - REGRESSION: 270951@main [ iOS17 ] imported/w3c/web-platform-tests/html/semantics/disabled-elements/disabled-event-dispatch.tentative.html (layout-test) is a constant text failure
Summary: REGRESSION: 270951@main [ iOS17 ] imported/w3c/web-platform-tests/html/semant...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ahmad Saleem
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-12-07 12:37 PST by Dawn Morningstar
Modified: 2023-12-07 22:49 PST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dawn Morningstar 2023-12-07 12:37:45 PST
imported/w3c/web-platform-tests/html/semantics/disabled-elements/disabled-event-dispatch.tentative.html 
is a constant text failure after 270951@main

HISTORY:
https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fsemantics%2Fdisabled-elements%2Fdisabled-event-dispatch.tentative.html 

DIFF:
--- /Volumes/Data/worker/Apple-iOS-17-Simulator-Release-WK2-Tests/build/layout-test-results/imported/w3c/web-platform-tests/html/semantics/disabled-elements/disabled-event-dispatch.tentative-expected.txt
+++ /Volumes/Data/worker/Apple-iOS-17-Simulator-Release-WK2-Tests/build/layout-test-results/imported/w3c/web-platform-tests/html/semantics/disabled-elements/disabled-event-dispatch.tentative-actual.txt
@@ -20,8 +20,8 @@
 PASS Testing click events when clicking child of disabled my-control.
 PASS Testing click events when clicking disabled button.
 PASS Testing click events when clicking disabled my-control.
-PASS Testing dblclick events when clicking child of disabled button.
-PASS Testing dblclick events when clicking child of disabled my-control.
+FAIL Testing dblclick events when clicking child of disabled button. assert_equals: child element received dblclick events expected true but got false
+FAIL Testing dblclick events when clicking child of disabled my-control. assert_equals: child element received dblclick events expected true but got false
 PASS Testing dblclick events when clicking disabled button.
 PASS Testing dblclick events when clicking disabled my-control.
 
DIFF-URL:
https://build.webkit.org/results/Apple-iOS-17-Simulator-Release-WK2-Tests/271609@main%20(987)/imported/w3c/web-platform-tests/html/semantics/disabled-elements/disabled-event-dispatch.tentative-diff.txt
Comment 1 Radar WebKit Bug Importer 2023-12-07 12:38:19 PST
<rdar://problem/119332865>
Comment 2 Dawn Morningstar 2023-12-07 12:41:07 PST
Starting on Ahmad whom committed 270951@main
Comment 3 Ahmad Saleem 2023-12-07 12:41:20 PST
Note it is not regression but rebaseline issue due to lack of double click on iOS.
Comment 4 Ahmad Saleem 2023-12-07 12:41:48 PST
Will fix it later today.
Comment 5 Ahmad Saleem 2023-12-07 15:22:35 PST
Just my notes:

1) This test has now moved on WPT upstream - should we resync it again?

2) This test has two expectation files on 'iOS' platform:

platform/ios-simulator-16-wk2/imported/w3c/web-platform-tests/html/semantics/disabled-elements/disabled-event-dispatch.tentative-expected.txt

and

platform/ios/imported/w3c/web-platform-tests/html/semantics/disabled-elements/disabled-event-dispatch.tentative-expected.txt

^ Looks into failing file and 'expected' file: It seems to be first one: https://ews-build.s3-us-west-2.amazonaws.com/iOS-17-Simulator-WPT-WK2-Tests-EWS/1ce694b9-5758/imported/w3c/web-platform-tests/html/semantics/disabled-elements/disabled-event-dispatch.tentative-expected.txt

Which we need to update.
Comment 6 EWS 2023-12-07 22:49:53 PST
Committed 271716@main (b8b425ed2bb3): <https://commits.webkit.org/271716@main>

Reviewed commits have been landed. Closing PR #21478 and removing active labels.