WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
26600
StringImpl::copy() no longer copies empty string correctly
https://bugs.webkit.org/show_bug.cgi?id=26600
Summary
StringImpl::copy() no longer copies empty string correctly
Alexey Proskuryakov
Reported
2009-06-22 00:54:30 PDT
StringImpl::copy() should not ever return per-thread empty string, because this function's result is for using on other threads. This was broken in <
http://trac.webkit.org/changeset/41917
> - StringImpl::create() has a special case for empty strings, so calling it is not appropriate.
Attachments
proposed fix
(1.63 KB, patch)
2009-06-22 12:11 PDT
,
Alexey Proskuryakov
levin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2009-06-22 12:11:52 PDT
Created
attachment 31663
[details]
proposed fix
Alexey Proskuryakov
Comment 2
2009-06-22 13:14:51 PDT
Committed revision 44952.
Alexey Proskuryakov
Comment 3
2009-06-25 21:27:02 PDT
See <
rdar://6964477
> and its duplicates.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug