Bug 26591 – Support revivers in JSON.parse

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Oliver Hunt]

As in title

[Oliver Hunt]

Created attachment 31698 [details]
JSON.parse with reviver support

[Darin Adler]

Comment on attachment 31698 [details]
JSON.parse with reviver support

> +        (JSC::):

Please remove this garbage line inserted by the script.

> +    JSValue callReviver(JSValue unfiltered, JSValue property) {

Please move this brace onto a separate line.

> +        JSValue args[] = {property, unfiltered};

Could you add spaces inside the braces please?

I'm worried that the arguments here are in the opposite order from the actual JavaScript function.

> +                array->setIndex(indexStack.last(), callReviver(outValue, jsString(m_exec, UString::from(indexStack.last()))));

Gosh that UString::from is going to be slow!

> +    Walker texasRanger(exec, asObject(function), callType, callData);
> +    return texasRanger.walk(unfiltered);

You can just put this on one line and so you won't have to apologize to our friends from Texas.

You forgot to include the expected results.

r=me if you fix these things

[Oliver Hunt]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	JavaScriptCore/ChangeLog
	M	JavaScriptCore/runtime/JSONObject.cpp
	M	LayoutTests/ChangeLog
	M	LayoutTests/fast/js/JSON-parse-expected.txt
	M	LayoutTests/fast/js/resources/JSON-parse.js
Committed r44968