RESOLVED FIXED 265891
Remove strange parentElement() code from HitTestResult 
https://bugs.webkit.org/show_bug.cgi?id=265891
Summary Remove strange parentElement() code from HitTestResult
Ahmad Saleem
Reported 2023-12-05 11:46:57 PST
Hi Team, While looking through clean-ups, I came across another potential from Blink's commit: Blink Commit: https://chromium.googlesource.com/chromium/blink/+/ceea705be631379fd0d012d4f20128ad3e7296ea "This code doesn't make any sense, why would the parentElement() be in the document if the node wasn't? It came from http://src.chromium.org/viewvc/blink?view=revision&revision=23994 7 years ago when the HitTestResult was actually stored in the Event, but even then it doesn't seem to make sense." WebKit Source: https://searchfox.org/wubkat/rev/1a7afa1ea1ff078e0856c604cc572aa47d35f2eb/Source/WebCore/rendering/HitTestResult.cpp#796 Just wanted to raise to get input so we can do this clean-up. Thanks!
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-12-12 11:47:22 PST
<rdar://problem/119566622>
Ahmad Saleem
Comment 2 2023-12-18 18:11:05 PST
Draft PR - https://github.com/WebKit/WebKit/pull/22003
EWS
Comment 3 2023-12-19 06:31:02 PST
Committed 272265@main (ceaf6d34ab11): <https://commits.webkit.org/272265@main> Reviewed commits have been landed. Closing PR #22003 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.