RESOLVED FIXED 265881
[IFC][Ruby] Nested rubies with interlinear annotations pushes their ancestors' interlinear annotations vertically 
https://bugs.webkit.org/show_bug.cgi?id=265881
Summary [IFC][Ruby] Nested rubies with interlinear annotations pushes their ancestors...
zalan
Reported 2023-12-05 09:32:01 PST
to avoid annotation overlapping
Attachments
[fast-cq]Patch (11.28 KB, patch)
2023-12-05 09:41 PST, zalan 		koivisto: review+
zalan: commit-queue-
DetailsFormatted DiffDiff
Patch (11.69 KB, patch)
2023-12-05 17:41 PST, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2023-12-05 09:41:52 PST
Created attachment 468899 [details] [fast-cq]Patch
Antti Koivisto
Comment 2 2023-12-05 09:46:37 PST
Comment on attachment 468899 [details] [fast-cq]Patch View in context: https://bugs.webkit.org/attachment.cgi?id=468899&action=review > Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:1101 > + auto placeAndSizeAnnotationBox = [&] { > + auto visualBorderBoxTopLeft = RubyFormattingContext::placeAnnotationBox(rubyBaseLayoutBox, baseMarginBoxRect, formattingContext); > + auto visualContentBoxSize = RubyFormattingContext::sizeAnnotationBox(rubyBaseLayoutBox, formattingContext); > + auto& annotationBoxGeometry = formattingContext.geometryForBox(*annotationBox); > + annotationBoxGeometry.setTopLeft(toLayoutPoint(visualBorderBoxTopLeft)); > + annotationBoxGeometry.setContentBoxSize(toLayoutSize(visualContentBoxSize)); > + }; > + placeAndSizeAnnotationBox(); so lambda
zalan
Comment 3 2023-12-05 10:58:06 PST
(In reply to Antti Koivisto from comment #2) > Comment on attachment 468899 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=468899&action=review > > > Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:1101 > > + auto placeAndSizeAnnotationBox = [&] { > > + auto visualBorderBoxTopLeft = RubyFormattingContext::placeAnnotationBox(rubyBaseLayoutBox, baseMarginBoxRect, formattingContext); > > + auto visualContentBoxSize = RubyFormattingContext::sizeAnnotationBox(rubyBaseLayoutBox, formattingContext); > > + auto& annotationBoxGeometry = formattingContext.geometryForBox(*annotationBox); > > + annotationBoxGeometry.setTopLeft(toLayoutPoint(visualBorderBoxTopLeft)); > > + annotationBoxGeometry.setContentBoxSize(toLayoutSize(visualContentBoxSize)); > > + }; > > + placeAndSizeAnnotationBox(); > > so lambda super lambda
zalan
Comment 4 2023-12-05 17:41:44 PST
Created attachment 468905 [details] Patch
EWS
Comment 5 2023-12-05 22:00:30 PST
Committed 271594@main (19c64d9bd822): <https://commits.webkit.org/271594@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 468905 [details].
Radar WebKit Bug Importer
Comment 6 2023-12-05 22:01:16 PST
<rdar://problem/119234934>
Note You need to log in before you can comment on or make changes to this bug.