WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
265813
[WPE][GTK] Remove pkg-config use from FindLibBacktrace.cmake
https://bugs.webkit.org/show_bug.cgi?id=265813
Summary
[WPE][GTK] Remove pkg-config use from FindLibBacktrace.cmake
Michael Catanzaro
Reported
2023-12-04 13:09:13 PST
Currently FindLibBacktrace.cmake uses pkg-config expecting to find a backtrace.pc, but I don't think libbacktrace from
https://github.com/ianlancetaylor/libbacktrace
actually installs any such pkg-config file. At least, I've failed to find any pkg-config file in the source repo, and I also couldn't find any code that generates it. So, let's remove this and rely on CMake heuristics to hopefully find the library. Also, I notice that libbacktrace has no upstream releases on GitHub, so I think it's too soon for it to be packaged in distros or enabled by default. It's actually not clear if any releases of this library are ever planned. It seems that upstream considers every commit to be "version 1.0" rather than picking a commit to be a release, which is not confidence-inspiring. This could probably be easily fixed, but in the meantime, let's leave this option off by default for now. Hopefully eventually it will become more clear whether libbacktrace is serious about being packaged by distros or not.
Attachments
Add attachment
proposed patch, testcase, etc.
Michael Catanzaro
Comment 1
2023-12-04 13:09:49 PST
(This is a continuation from discussion in
bug #262104
.)
Michael Catanzaro
Comment 2
2023-12-04 13:11:57 PST
Pull request:
https://github.com/WebKit/WebKit/pull/21294
EWS
Comment 3
2023-12-19 13:20:23 PST
Committed
272292@main
(0ff5cc83058a): <
https://commits.webkit.org/272292@main
> Reviewed commits have been landed. Closing PR #21294 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug