Bug 265749 - REGRESSION(268561@main): generate-bindings-all.pl: [CMake] doesn't account for certain IDL changes
Summary: REGRESSION(268561@main): generate-bindings-all.pl: [CMake] doesn't account fo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-12-03 01:55 PST by Anne van Kesteren
Modified: 2023-12-04 16:48 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anne van Kesteren 2023-12-03 01:55:01 PST 
https://github.com/WebKit/WebKit/pull/21232 is failing to compile across the Linux bots due to what appears to be the incremental build not realizing the IDL changes are significant.

For instance:

In file included from /app/webkit/WebKitBuild/WPE/Release/WebCore/DerivedSources/unified-sources/UnifiedSource-3a52ce78-109.cpp:2:
/app/webkit/WebKitBuild/WPE/Release/WebCore/DerivedSources/JSPerformanceNavigationTiming.cpp: In function ‘JSC::EncodedJSValue WebCore::jsPerformanceNavigationTimingPrototypeFunction_toJSONBody(JSC::JSGlobalObject*, JSC::CallFrame*, JSPerformanceNavigationTiming*)’:
/app/webkit/WebKitBuild/WPE/Release/WebCore/DerivedSources/JSPerformanceNavigationTiming.cpp:437:35: error: ‘serverTimingEnabled’ is not a member of ‘WebCore::DeprecatedGlobalSettings’
Comment 1 Fujii Hironori 2023-12-04 13:55:56 PST 
The generated JSPerformanceNavigationTiming.dep contains the following line:

> JSPerformanceNavigationTiming.h : PerformanceResourceTiming.idl PerformanceEntry.idl

If PerformanceResourceTiming.idl is modified, JSPerformanceNavigationTiming.{h,cpp} should be regenerated.

This is a regression of 268561@main (bug#261364).
Comment 2 Fujii Hironori 2023-12-04 14:04:32 PST 
Pull request: https://github.com/WebKit/WebKit/pull/21299
Comment 3 Michael Catanzaro 2023-12-04 14:22:09 PST 
Is there a reason the dependency file doesn't simply also contain JSPerformanceNavigationTiming.cpp? Why only regenerate the header and not also the generated source file?
Comment 4 EWS 2023-12-04 14:28:58 PST 
Committed 271510@main (e4ad7f1cf28a): <https://commits.webkit.org/271510@main>

Reviewed commits have been landed. Closing PR #21299 and removing active labels.
Comment 5 Radar WebKit Bug Importer 2023-12-04 14:30:18 PST 
<rdar://problem/119153459>
Comment 6 Fujii Hironori 2023-12-04 14:35:34 PST 
(In reply to Michael Catanzaro from comment #3)
> Is there a reason the dependency file doesn't simply also contain
> JSPerformanceNavigationTiming.cpp? Why only regenerate the header and not
> also the generated source file?

Oh, I missed your comment.
generate-bindings.pl gerenates both .cpp and .h at the same time.
So, it doesn't need .cpp line in the .dep file.

And, generate-bindings-all.pl process only the file line of .dep files at the moment.
https://github.com/WebKit/WebKit/blob/906329430eb27e345bf525433f393e8a3912936a/Source/WebCore/bindings/scripts/generate-bindings-all.pl#L201