RESOLVED FIXED265729
[offlineasm] Incremental build failure when generator is interrupted 
https://bugs.webkit.org/show_bug.cgi?id=265729
Summary [offlineasm] Incremental build failure when generator is interrupted
Elliott Williams
Reported 2023-12-02 15:21:45 PST
It generators its headers non-atomically, so if the script is interrupted due to a build failure in a parallel task, it leaves a partially-written header. The build system (XCBuild, at least, I didn't try ninja) can't tell that this header is incomplete, so its presence breaks subsequent rebuilds.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-12-02 15:21:54 PST
<rdar://problem/119079705>
Elliott Williams
Comment 2 2023-12-02 15:26:31 PST
Pull request: https://github.com/WebKit/WebKit/pull/21217
EWS
Comment 3 2023-12-06 15:24:19 PST
Committed 271640@main (97b3a2dd3db7): <https://commits.webkit.org/271640@main> Reviewed commits have been landed. Closing PR #21217 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.