Bug 265729 - [offlineasm] Incremental build failure when generator is interrupted
Summary: [offlineasm] Incremental build failure when generator is interrupted
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Williams
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-12-02 15:21 PST by Elliott Williams
Modified: 2023-12-06 15:24 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Williams 2023-12-02 15:21:45 PST 
It generators its headers non-atomically, so if the script is interrupted due to a build failure in a parallel task, it leaves a partially-written header. The build system (XCBuild, at least, I didn't try ninja) can't tell that this header is incomplete, so its presence breaks subsequent rebuilds.
Comment 1 Radar WebKit Bug Importer 2023-12-02 15:21:54 PST 
<rdar://problem/119079705>
Comment 2 Elliott Williams 2023-12-02 15:26:31 PST 
Pull request: https://github.com/WebKit/WebKit/pull/21217
Comment 3 EWS 2023-12-06 15:24:19 PST 
Committed 271640@main (97b3a2dd3db7): <https://commits.webkit.org/271640@main>

Reviewed commits have been landed. Closing PR #21217 and removing active labels.